lkml.org 
[lkml]   [2008]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] add ksm kernel shared memory driver.
    > +	r = !memcmp(old_digest, sha1_item->sha1val, SHA1_DIGEST_SIZE);
    > + mutex_unlock(&sha1_lock);
    > + if (r) {
    > + char *old_addr, *new_addr;
    > + old_addr = kmap_atomic(oldpage, KM_USER0);
    > + new_addr = kmap_atomic(newpage, KM_USER1);
    > + r = !memcmp(old_addr+PAGEHASH_LEN, new_addr+PAGEHASH_LEN,
    > + PAGE_SIZE-PAGEHASH_LEN);

    NAK - this isn't guaranteed to be robust so you could end up merging
    different pages one provided by a malicious attacker.


    \
     
     \ /
      Last update: 2008-11-28 18:01    [W:0.019 / U:32.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site