Messages in this thread | | | Date | Thu, 27 Nov 2008 05:10:23 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH 6/6] fs: Introduce kern_mount_special() to mount special vfs |
| |
On Thu, Nov 27, 2008 at 11:04:38AM +0100, Eric Dumazet wrote: > Hum.. we have a superblock flag already, but testing it in mntput()/mntget() > is going to be a litle bit expensive if we add a derefence ? > > if (mnt && mnt->mnt_sb->s_flags & MS_SPECIAL) { > ... > }
Well, run a benchmark to see if it makes any difference. And when it does please always set the mount flag from the common mount code when it's set on the superblock, and document that this is the only valid way to set it.
| |