Messages in this thread | | | Date | Thu, 27 Nov 2008 16:09:52 +0100 | From | "Frédéric Weisbecker" <> | Subject | Re: [PATCH] tracing/function-branch-tracer: enhancements for the trace output |
| |
2008/11/27 Ingo Molnar <mingo@elte.hu>: > if you look at it on a console where you look at code, it all looks > like a straight line: > > > 0) | sys_read() { > 0) 0.331 us | fget_light(); > 0) | vfs_read() { > 0) | rw_verify_area() { > 0) | security_file_permission() { > 0) 0.306 us | cap_file_permission(); > 0) 0.300 us | cap_file_permission(); > 0) 8.909 us | } > 0) 0.993 us | } > 0) 11.649 us | } > 0) | do_sync_read() { > . ------------------------- > 0) ==> [ bash-2794 => cat-1234 ] > ------------------------- > > > as if the code to the right was on a sheet of paper. > > If i understand you correct, are you suggesting this format: > > 0) | sys_read() { > 0) 0.331 us fget_light(); > 0) | vfs_read() { > 0) | rw_verify_area() { > 0) | security_file_permission() { > 0) 0.306 us cap_file_permission(); > 0) 0.300 us cap_file_permission(); > 0) 8.909 us } > 0) 0.993 us } > 0) 11.649 us } > 0) | do_sync_read() { > . ------------------------- > 0) ==> [ bash-2794 => cat-1234 ] > ------------------------- > > i dont think that looks very good.
Hmm. I must confess that it draws a useful boundary for the eyes. Ok.
| |