lkml.org 
[lkml]   [2008]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/function-branch-tracer: enhancements for the trace output
2008/11/27 Ingo Molnar <mingo@elte.hu>:
> We can still add the overhead signs.
>
> We still have a single space in the first column before the CPU number
> (that looks better when these traces are pasted into email, which is
> one of the most common uses of them), and we can add the sign there.
>
> I.e. something like this:
>
>> > ---------------------------------------------------------
>> > CPU) cost | function
>> > ---------------------------------------------------------
>> >
>> > 0) | sys_read() {
>> > 0) 0.331 us | fget_light();
>> > 0) | vfs_read() {
>> > 0) | rw_verify_area() {
>> > 0) | security_file_permission() {
>> > 0) 0.306 us | cap_file_permission();
>> > 0) 0.300 us | cap_file_permission();
>> > 0) 8.909 us | }
>> > 0) 0.993 us | }
>> > +0) 11.649 us | }
>> > 0) | do_sync_read() {
>> > 0) | sock_aio_read() {
>> > 0) | __sock_recvmsg() {
>> > 0) | security_socket_recvmsg() {
>> > !0) 100.319 us | cap_socket_recvmsg();
>> > ---------------------------------------------------------
>
> Or we could add them to the function name bit - there we have two free
> space characters anyway:
>
> Something like this:
>
>> > ---------------------------------------------------------
>> > CPU) cost | function
>> > ---------------------------------------------------------
>> >
>> > 0) | sys_read() {
>> > 0) 0.331 us | fget_light();
>> > 0) | vfs_read() {
>> > 0) | rw_verify_area() {
>> > 0) | security_file_permission() {
>> > 0) 0.306 us | cap_file_permission();
>> > 0) 0.300 us | cap_file_permission();
>> > 0) 8.909 us | }
>> > 0) 0.993 us | }
>> > 0) 11.649 us |+ }
>> > 0) | do_sync_read() {
>> > 0) | sock_aio_read() {
>> > 0) | __sock_recvmsg() {
>> > 0) | security_socket_recvmsg() {
>> > 0) 100.319 us |! cap_socket_recvmsg();
>> > ---------------------------------------------------------
>
> Hm?

I like it before the CPU number. The main purpose would be to scroll
quickly the file and find the overheads. That would be easy if set as
a first character.

I will set it as a default disabled option.



>
>> I don't know, perhaps that will actually be better in practice...
>
> i think it will be better. I'm biased, so i gave the output to two
> people with good visual taste (one of them female), [note, i gave them
> the mockup from the previous mail] and the first question of both of
> them was: "why arent the times on the left?".

Really?
Actually yes, I'm certainly biased too.

> I think we could make the time column a trace_option as well -
> default-enabled.

Ok, I will apply it.


\
 
 \ /
  Last update: 2008-11-27 15:47    [W:0.155 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site