lkml.org 
[lkml]   [2008]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 05/24] perfmon: X86 generic code (x86)
On Thu, Nov 27, 2008 at 1:45 PM, Andi Kleen <andi@firstfloor.org> wrote:
>> What if a threads reprograms the counters while another is reading them?
>
> In the worst case you get an invalid event, which is then discarded.
> I think. I've never tried to understand it in all details, but
> at least it seems to work.
>
>> How is the buffer reset?
>
> drivers/oprofile/cpu_buffer.c:
>
> /* Resets the cpu buffer to a sane state. */
> void cpu_buffer_reset(struct oprofile_cpu_buffer *cpu_buf)
> {
> /* reset these to invalid values; the next sample
> * collected will populate the buffer with proper
> * values to initialize the buffer
> */
> cpu_buf->last_is_kernel = -1;
> cpu_buf->last_task = NULL;
> }
>
What about a thread doing this and another one in the middle of read the buffer?

Or what about a thread trying to reset the buffer while you're processing an PMU
interrupt on another CPU. I know each buffer is per-CPU, but that does not
prevent two threads for trying to operate on it at the same time from
different CPUs.


\
 
 \ /
  Last update: 2008-11-27 14:35    [W:0.096 / U:2.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site