Messages in this thread | | | Date | Thu, 27 Nov 2008 14:27:12 +0300 | From | "Cyrill Gorcunov" <> | Subject | Re: [PATCH 4/5] x86: ret_from_fork - add CFI proc annotation |
| |
On Thu, Nov 27, 2008 at 1:15 PM, Alexander van Heukelum <heukelum@fastmail.fm> wrote: > > On Wed, 26 Nov 2008 22:17:03 +0300, gorcunov@gmail.com said: >> From: Cyrill Gorcunov <gorcunov@gmail.com> >> >> ret_from_fork is definitly procedure so mark it as that. >> >> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> >> --- >> arch/x86/kernel/entry_64.S | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S >> index c409f73..a21be86 100644 >> --- a/arch/x86/kernel/entry_64.S >> +++ b/arch/x86/kernel/entry_64.S >> @@ -370,6 +370,7 @@ END(save_paranoid) >> */ >> /* rdi: prev */ >> ENTRY(ret_from_fork) >> + CFI_STARTPROC >> DEFAULT_FRAME >> push kernel_eflags(%rip) >> CFI_ADJUST_CFA_OFFSET 8 > > This is not needed/wanted. DEFAULT_FRAME includes "CFI_STARTPROC simple" > already. > > Alexander > >> 1.6.0.4.603.gbc9c0 >> > -- > Alexander van Heukelum > heukelum@fastmail.fm > > -- > http://www.fastmail.fm - The professional email service > >
Indeed, thanks (such an indirect and nested definition sometime confusing)
| |