Messages in this thread | | | Subject | Re: [PATCH 2/5] ftrace: use code patching for ftrace graph tracer | From | Harvey Harrison <> | Date | Wed, 26 Nov 2008 00:44:48 -0800 |
| |
On Wed, 2008-11-26 at 00:35 -0800, Andrew Morton wrote: > On Wed, 26 Nov 2008 00:27:04 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote: > > > if (code[0] != 0xe9 || old_offset != load32_noalign(&code[1])) > > > > This is similar to the new API in -mm load_le32_noalign, but I > > don't think it would be worth load_u32_noalign...load32 should > > be enough. > > > > > > > > + return -EINVAL; > > > > > > + > > > > > > + *(int *)(&code[1]) = new_offset; > > > > > > > > > > Might be able to use put_unaligned_foo() here. > > > > > > > > > > > > > put_unaligned(new_offset, (int *)(&code[1])); > > > > > > > > In a similar vein to above, this becomes: > > > > store32_noalign(&code[1], new_offset); > > > > yes, that's much better than the party tricks with magical sizeof, > which forces you to run around and check the types of everything. > > I've seen people doing get_user() on `long' types and such things > occasionally. >
Do you want to carry the patches to move to the new helpers until they hit mainline, or would you rather I waited until they can go through maintainer trees?
I've got the pile ready removing all of the get/put_{endian} and moving to the load/store API. Not much left after that to just remove the magical sizeof versions too. Just let me know what timing you'd prefer.
Also, all of this ends up being so intertwined in the aligned/unaligned cases that I'd like to move most of Documentation/unaligned_memory_access.txt into a new alignment_and_byteorder.txt to cover all of these new helpers.
I started most of a byteorder document, but constantly referring to the other file made it a bit tiresome, would you mind a consolidated document?
Harvey
| |