lkml.org 
[lkml]   [2008]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] x86: ret_from_fork - get rid of jump back
[Andi Kleen - Wed, Nov 26, 2008 at 09:04:33PM +0100]
| gorcunov@gmail.com writes:
| > --- a/arch/x86/kernel/entry_64.S
| > +++ b/arch/x86/kernel/entry_64.S
| > @@ -379,7 +379,10 @@ ENTRY(ret_from_fork)
| > GET_THREAD_INFO(%rcx)
| > testl $(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT),TI_flags(%rcx)
| > CFI_REMEMBER_STATE
| > - jnz rff_trace
| > + jz rff_action
| > + movq %rsp,%rdi
| > + call syscall_trace_leave
| > + GET_THREAD_INFO(%rcx)
|
| The uncommon path is supposed to be out of line. I don't think
| the CPU will like that.
|
| -Andi
|
| > rff_action:
|
| --
| ak@linux.intel.com
|

Aha! Thanks Andi for review.

- Cyrill -


\
 
 \ /
  Last update: 2008-11-26 21:13    [from the cache]
©2003-2011 Jasper Spaans