lkml.org 
[lkml]   [2008]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/function-return-tracer: set a more human readable output

On Wed, 26 Nov 2008, Fr?d?ric Weisbecker wrote:

> 2008/11/26 Ingo Molnar <mingo@elte.hu>:
> > 1) Compression of non-nested calls into a single line.
> >
> > Implementing this probably necessiates some trickery with the
> > ring-buffer: we'd have to look at the next entry as well and see
> > whether it closes the function call.
>
>
> I wanted to do so. That's not so easy, I guess I will not only have to read
> the next entry. I'll have to modify it to avoid the next entry to
> print a closing brace.

You could run a ring_buffer_read(iter->buffer_iter[iter->cpu], NULL)
and that will consume the next entry, so it will not print.

> But I don't think that would be a problem.
> Note with this method that if there is a context switch or an
> interrupt between the entry and
> the return of a leaf function, it will not anymore be considered as a non-nested
> function on its output.
> But the case would be rare enough, so I will apply this.

Yeah, we would not care about that case. In fact it may be best to keep it
as is.

-- Steve



\
 
 \ /
  Last update: 2008-11-26 18:11    [W:0.191 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site