Messages in this thread | | | Date | Wed, 26 Nov 2008 13:22:17 +0100 | From | Andi Kleen <> | Subject | Re: [patch 05/24] perfmon: X86 generic code (x86) |
| |
On Wed, Nov 26, 2008 at 11:05:29PM +1100, Stephen Rothwell wrote: > Hi Andi, > > On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@firstfloor.org> wrote: > > > > > + * x86 does not need extra alignment requirements for the sampling buffer > > > + */ > > > +#define PFM_ARCH_SMPL_ALIGN_SIZE 0 > > > + > > > +asmlinkage void pmu_interrupt(void); > > > + > > > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits) > > > > All these bitmap wrappers just seem like unnecessary obfuscation. > > Could you just drop them and call the standard functions directly? > > These were added after comments from the PowerPC maintainer since how the > bitmaps are accessed needs to be arch specific.
Why? They should not be exported outside, so endian shouldn't matter, should it?
-Andi
| |