Messages in this thread | | | Date | Tue, 25 Nov 2008 11:13:42 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] 8250: Eliminate compile warning of 8250.c |
| |
> The logic here is strange...
Why
> If you used old compiler, you would get a warning, and you thought that's > ensured we won't delete a intended assignment by mistake.
No.. if you hid the warning by hacking around the compiler mistake with extra bogus assignments you would hide a future mistake. > > If you used new compiler, you wouldn't get a warning, and you think this time > the compiler get it right.
The compiler does now get it right - I checked.
Alan
| |