Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH] memcg reclaim shouldn't change zone->recent_rotated statics. | Date | Wed, 26 Nov 2008 09:13:31 +0900 (JST) |
| |
> On Tue, 25 Nov 2008 12:22:53 +0900 (JST) > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > > + if (scan_global_lru(sc)) > > mutter. scan_global_lru() is a terrible function name. Anyone reading > that code would expect that this function, umm, scans the global LRU.
yup.
> gcc has a nice convention wherein such functions have a name ending in > "_p" (for "predicate"). Don't do this :)
however, "_p" isn't linux convention. so, I like "is_" or "can_" (or likes somethingelse) prefix :)
| |