lkml.org 
[lkml]   [2008]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/1] Slight fix for locking-fix patch to remove compiler warning
Rusty Russell wrote:
> We can't call cpuset_cpus_allowed_locked() with the rq lock held.
> However, the rq lock merely protects us from (1) cpu_online_mask changing
> and (2) someone else changing p->cpus_allowed.
>
> The first can't happen because we're being called from a cpu hotplug
> notifier. The second doesn't really matter: we are forcing the task off
> a CPU it was affine to, so we're not doing very well anyway.
>
> So we remove the rq lock from this path, and all is good.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>

Remove rq since it's no longer referenced.

Signed-off-by: Mike Travis <travis@sgi.com>
---
kernel/sched.c | 1 -
1 file changed, 1 deletion(-)
--- linux-2.6.28-tip-cpumasks.orig/kernel/sched.c
+++ linux-2.6.28-tip-cpumasks/kernel/sched.c
@@ -6126,7 +6126,6 @@ static int __migrate_task_irq(struct tas
*/
static void move_task_off_dead_cpu(int dead_cpu, struct task_struct *p)
{
- struct rq *rq;
int dest_cpu;
/* FIXME: Use cpumask_of_node here. */
cpumask_t _nodemask = node_to_cpumask(cpu_to_node(dead_cpu));

\
 
 \ /
  Last update: 2008-11-25 17:59    [from the cache]
©2003-2011 Jasper Spaans