lkml.org 
[lkml]   [2008]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [Patch 2/3] OProfile SPU event profiling support for IBM Cell processor
    Date
    On Tuesday 25 November 2008, Carl Love wrote:
    >
    > This patch basically rearranges the code a bit to make it easier to
    > just add the needed SPU event based profiling routines. The second
    > kernel patch contains the new spu event based profiling code.

    The cleanup looks fine, but should get a unique patch name, e.g.
    '[PATCH 2/3] powerpc/cell/oprofile: clean up event handling' to
    make the shortlog more meaningful. No need to mention in the changelog
    what the other patch does.

    Please mention that this patch is not supposed to change any behaviour.

    > Signed-off-by: Carl Love <carll@us.ibm.com>

    Acked-by: Arnd Bergmann <arnd@arndb.de>


    \
     
     \ /
      Last update: 2008-11-25 17:07    [W:5.613 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site