Messages in this thread | | | Date | Tue, 25 Nov 2008 16:43:55 +0200 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple_strtoul |
| |
On Tue, Nov 25, 2008 at 02:13:03PM +0100, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Since bridge is unsigned, it would seem better to use simple_strtoul that > simple_strtol. > > A simplified version of the semantic patch that makes this change is as > follows: (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @r2@ > long e; > position p; > @@ > > e = simple_strtol@p(...) > > @@ > position p != r2.p; > type T; > T e; > @@ > > e = > - simple_strtol@p > + simple_strtoul > (...) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
Ingo, can you please push?
Thanks, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/
| |