Messages in this thread | | | Date | Mon, 24 Nov 2008 07:16:59 -0500 | From | Mathieu Desnoyers <> | Subject | Re: [ltt-dev] [RFC PATCH] Poll : add poll_wait_set_exclusive (fixing thundering herd problem in LTTng) |
| |
* KOSAKI Motohiro (kosaki.motohiro@jp.fujitsu.com) wrote: > > > I fully agreed this feature is needed. > > > Actually, I've made similar patch at one years ago. > > > > > > http://marc.info/?l=linux-kernel&m=120257050719087&w=2 > > > > > > > > > but, I have one question. > > > My version have epoll support, but yours donesn't have. > > > Is it intensionally? > > > > > > this is just dumb question, it doesn't mean any objection. > > > > Hrm, actually, your patch seems cleaner than mine, but it adds a branch > > in the standard hotpath, which mine does not do (but I am not sure it is > > such an important optimization...). > > Why do you think poll_wait() is hotpath? > I think sysm_poll() isn't hotpath because it often cause task sleeping. > > > > Is there any reason why your patch > > did not get merged ? > > my patch was developed for a part of mem_notify patch series. > but the mem_notify was naked by akpm. > therefore it lost merging motivation ;-) > > Ingo, I'll rebase and post my patch for -tip tommorow. > Could you please review it? > > > > The only reason I did not make a epoll version is simply because LTTng > > currently does not support it. :) > > thanks. > I understand your original intension. >
Great, please CC me on this one so I can integrate it to the LTTng tree.
Mathieu
-- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |