lkml.org 
[lkml]   [2008]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] tracing/function-return-tracer: Support for dynamic ftrace on function return tracer

On Sun, 16 Nov 2008, Frederic Weisbecker wrote:
>
> static void ftrace_replace_code(int enable)
> @@ -1405,10 +1417,17 @@ int register_ftrace_function(struct ftrace_ops *ops)
> return -1;
>
> mutex_lock(&ftrace_sysctl_lock);
> +
> + if (ftrace_tracing_type == FTRACE_TYPE_RETURN) {
> + ret = -EBUSY;
> + goto out;
> + }
> +

Why do we need to disable all new tracing functions when we do return
tracing??

-- Steve

> ret = __register_ftrace_function(ops);
> ftrace_startup();
> - mutex_unlock(&ftrace_sysctl_lock);
>
> +out:
> + mutex_unlock(&ftrace_sysctl_lock);
> return ret;
> }
>


\
 
 \ /
  Last update: 2008-11-24 23:11    [W:1.951 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site