Messages in this thread | | | Date | Mon, 24 Nov 2008 10:04:50 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [RFC -tip] x86: introduce ENTRY(KPROBE)_X86 assembly helpers to catch unbalanced declaration |
| |
Alexander van Heukelum wrote: > > The problem is that ENTRY(interrupt) is done in init.rodata, and > ENTRY(irq_entries_start) is done in .text. So inside the .S-file, > they are nested, but in the .o-file they are separate. Instead of > removing ENTRY(irq_entries_start), I think we should just expand to: > > .section .init.rodata,"a" > .p2align 5 > .global interrupt > interrupt: > > and > > size interrupt, .-interrupt > > But the only importance I can think of is that this keeps both > the "interrupt" array and irq_entries_start visible in debugging > information. > > Alternatively, we could probably do away with the interrupt > array entirely. We _know_ how the irq stubs are structured and > irq_entries_start is in principle enough information to reconstruct > all information in interrupt. >
I'd rather not get rid of the interrupt array. But more fundamentally, interrupt is a data symbol, not an entry point.
-hpa
| |