Messages in this thread Patch in this message | | | From | Chr <> | Subject | [PATCH] p54: fix wmm queue settings | Date | Mon, 24 Nov 2008 13:34:38 +0100 |
| |
This patch fixes a regression (introduced by 453fae72b2f19 "p54: more definitions form lmac_longbow.h and pda.h" )
It turned out that the "ret" variable wasn't initialized and this caused the following warnings/errors to appear:
wmaster1: failed to set TX queue parameters for queue 2 wmaster1: failed to set TX queue parameters for queue 3 wmaster1: failed to set TX queue parameters for queue 1 wmaster1: failed to set TX queue parameters for queue 0
Signed-off-by: Christian Lamparter <chunkeey@web.de> --- diff -Nurp a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c --- a/drivers/net/wireless/p54/p54common.c 2008-11-24 00:01:27.899490373 +0100 +++ b/drivers/net/wireless/p54/p54common.c 2008-11-24 13:07:09.053832187 +0100 @@ -1729,10 +1729,9 @@ static int p54_conf_tx(struct ieee80211_ if ((params) && !(queue > 4)) { P54_SET_QUEUE(priv->qos_params[queue], params->aifs, params->cw_min, params->cw_max, params->txop); + ret = p54_set_edcf(dev); } else ret = -EINVAL; - if (!ret) - ret = p54_set_edcf(dev); mutex_unlock(&priv->conf_mutex); return ret; }
| |