lkml.org 
[lkml]   [2008]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] x86: signal: cosmetic unification of sys_rt_sigreturn()

    * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

    > H. Peter Anvin wrote:
    > > Hiroshi Shimamoto wrote:
    > >>
    > >> +#ifdef CONFIG_X86_32
    > >> asmlinkage int sys_rt_sigreturn(unsigned long __unused)
    > >> {
    > >> struct pt_regs *regs = (struct pt_regs *)&__unused;
    > >>
    > >> return do_rt_sigreturn(regs);
    > >> }
    > >
    > > Why not:
    > >
    > > asmlinkage int sys_rt_sigreturn(struct pt_regs regs)
    > > {
    > > return do_rt_sigreturn(&regs);
    > > }
    > >
    > > ...?
    >
    > Good question. I didn't realize about that.
    > Will take a look.

    I've applied your 3 patches to tip/x86/signal - please send a patch on
    top of your current lineup, for the detail Peter pointed out.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2008-11-23 10:55    [W:0.020 / U:0.808 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site