Messages in this thread | | | From | "Yu, Fenghua" <> | Date | Sat, 22 Nov 2008 22:10:05 -0800 | Subject | RE: [PATCH] IA64: fix VT-d dma_mapping_error |
| |
>Hmm, intel_dma_mapping_error is used to test only the value that >intel_map_single() returns. If intel_map_single() returns a non-zero >dma address, it belongs to hwdev's domain. So intel_dma_mapping_error >can simply return 1 (failure) if the dma_addr is zero.
Then there is no usage of hwdev which is one of two parameters in intel_dma_mapping_error?
Maybe checking dma_addr only is good enough for the function? At least it's fast to check errors.
Thanks.
-Fenghua
| |