Messages in this thread | | | Date | Sat, 22 Nov 2008 21:43:51 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH fwd] poll: allow f_op->poll to sleep |
| |
Matthew Wilcox wrote: > On Sat, Nov 22, 2008 at 09:58:33AM +0100, Miklos Szeredi wrote: >> +int poll_schedule_timeout(struct poll_wqueues *pwq, int state, >> + ktime_t *expires, unsigned long slack) > > All callers of poll_schedule() and poll_schedule_timeout() pass > TASK_INTERRUPTIBLE. We can elide the 'state' argument.
Well, I wanted to keep it as to keep it more consistent with other schedule() functions but both Miklos and you don't seem to like it, so I might as well just drop it. Andrew, what do you think?
Thanks.
-- tejun
| |