lkml.org 
[lkml]   [2008]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: poll: allow f_op->poll to sleep, take #3
    On Sun, 23 Nov 2008, Tejun Heo wrote:

    > +static int pollwake(wait_queue_t *wait, unsigned mode, int sync, void *key)
    > +{
    > + struct poll_wqueues *pwq = wait->private;
    > + DECLARE_WAITQUEUE(dummy_wait, pwq->polling_task);
    > +
    > + set_mb(pwq->triggered, 1);
    > +
    > + /* perform the default wake up operation */
    > + return default_wake_function(&dummy_wait, mode, sync, key);
    > +}

    Wouldn't it be nicer to un-static try_to_wake_up() (or a wrapper) instead
    of setting up a fake wait queue just to use default_wake_function(), just
    to wake up a task?


    - Davide



    \
     
     \ /
      Last update: 2008-11-23 03:39    [W:0.018 / U:88.480 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site