[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/3] proc: Export statistics for softirq to /proc
    On Fri, 21 Nov 2008 17:07:43 -0800 Keika Kobayashi <> wrote:

    > > This uses for_each_online_cpu(), but below we use for_each_possible_cpu().
    > >
    > > Shouldn't we be consistent here so that at least the numbers will add
    > > up to the same thing?
    > >
    > > Probably for_each_possible_cpu() is best - people might want to see how
    > > many softirqs happened on a CPU which was recently offlined.
    > I understand this point. I'll fix it later.
    > There is same problem regarding /proc/interrupts.
    > Should we change from for_each_online_cpu() to for_each_possible_cpu(),
    > or is it too late?

    I assume that /proc/interrupts has been that way for a very long time,
    and nobody has noticed&complained. If we can find anyone who actually
    uses cpu hotplug then perhaps they could help us out here. But such
    people seem to be rare.

    I dunno. I guess we can leave /proc/interrupts alone.

     \ /
      Last update: 2008-11-22 02:37    [W:0.022 / U:11.900 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site