| Date | Fri, 21 Nov 2008 17:58:09 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 06/10] x86: add check code for map/unmap_sg code |
| |
please use this nice structure init style:
> + entry->type = DMA_DEBUG_SG; > + entry->dev = dev; > + entry->cpu_addr = sg_virt(s); > + entry->size = s->length; > + entry->dev_addr = s->dma_address; > + entry->direction = direction;
here too:
> + struct dma_debug_entry ref = { > + .type = DMA_DEBUG_SG, > + .dev = dev, > + .cpu_addr = sg_virt(s), > + .dev_addr = s->dma_address, > + .size = s->length, > + .direction = dir,
Ingo
|