lkml.org 
[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] IB/ehca: Fix lockdep failures for shca_list_lock
From
Date
On Fri, 2008-11-21 at 16:37 +0100, Joachim Fenkes wrote:

> + u64 flags;

> - spin_lock(&shca_list_lock);
> + spin_lock_irqsave(&shca_list_lock, flags);

That's wrong and I think will give a warning on all machines where
u64 != unsigned long. Might not particularly matter in this case.

Also, generally it seems wrong to say "fix lockdep failure" when the
patch really fixes a bug that lockdep happened to find.

johannes
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-11-21 17:05    [W:0.246 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site