lkml.org 
[lkml]   [2008]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] mfd: Fix define values of CS1_HIB_MODE.
Hi Mark,

I found a little mistake.
The define values are wrong.

It is written in the WM8350 DATA SHEET Rev 3.4 P285 that
CS1_HIB_MODE(bit 12) is disable at "1".

The following is it.

<WM8350 DATA SHEET Rev 3.4 P285>

REGISTER |BIT| LABEL | DESCRIPTION
ADDRESS | | |
---------+---+------------+-------------
R172(ACh)| 12|CS1_HIB_MODE| 0=leave current sink as in Active
| | | 1=disable current shik in Hibemate
Could you please check the following patch ?

Regards,
Naohiro Ooiwa

Signed-off-by: Naohiro Ooiwa <nooiwa@miraclelinux.com>
---
include/linux/mfd/wm8350/pmic.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mfd/wm8350/pmic.h b/include/linux/mfd/wm8350/pmic.h
index 656279a..078363b 100644
--- a/include/linux/mfd/wm8350/pmic.h
+++ b/include/linux/mfd/wm8350/pmic.h
@@ -83,8 +83,8 @@
#define WM8350_CS1_ISEL_SHIFT 0

/* Bit values for R172 (0xAC) */
-#define WM8350_CS1_HIB_MODE_DISABLE 0
-#define WM8350_CS1_HIB_MODE_LEAVE 1
+#define WM8350_CS1_HIB_MODE_DISABLE 1
+#define WM8350_CS1_HIB_MODE_LEAVE 0

#define WM8350_CS1_ISEL_220M 0x3F

--
1.5.4.1


\
 
 \ /
  Last update: 2008-11-20 12:27    [from the cache]
©2003-2011 Jasper Spaans