Messages in this thread | | | Date | Thu, 20 Nov 2008 23:06:22 +0100 | From | "stephane eranian" <> | Subject | Re: [patch] x86, bts: fix unlock problem in ds.c |
| |
On Thu, Nov 20, 2008 at 10:48 PM, Ingo Molnar <mingo@elte.hu> wrote: > > * stephane eranian <eranian@googlemail.com> wrote: > >> Markus, >> >> I think this patch is not quite right. You don't want to go out via >> out_unlock because you're going to call ds_put_context)() when you >> did not invoke the matching ds_get_context() (hidden in >> ds_alloc_context). It happens later in the ds_request() function. > > i noticed that, and fixed it via: > > 10db4ef: x86, PEBS/DS: fix code flow in ds_request() > > can you still see problems with it? > Well, I have lots of problems with ds.c so I have heavily modified the code therefore I have not pulled from any public tree in several days.
| |