lkml.org 
[lkml]   [2008]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 07/16] Blackfin SPI Driver: drop bogus cast and touchup dma label
    Date
    On Monday 17 November 2008, Bryan Wu wrote:
    > From: Mike Frysinger <vapier.adi@gmail.com>
    >
    > Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
    > Signed-off-by: Bryan Wu <cooloney@kernel.org>

    Acked-by: David Brownell <dbrownell@users.sourceforge.net>

    ... again, please to include real patch comments
    not just long $SUBJECT lines

    > ---
    > drivers/spi/spi_bfin5xx.c | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
    > index df424a2..a7c8976 100644
    > --- a/drivers/spi/spi_bfin5xx.c
    > +++ b/drivers/spi/spi_bfin5xx.c
    > @@ -1076,13 +1076,13 @@ static int setup(struct spi_device *spi)
    > */
    > if (chip->enable_dma && !drv_data->dma_requested) {
    > /* register dma irq handler */
    > - if (request_dma(drv_data->dma_channel, "BF53x_SPI_DMA") < 0) {
    > + if (request_dma(drv_data->dma_channel, "BFIN_SPI_DMA") < 0) {
    > dev_dbg(&spi->dev,
    > "Unable to request BlackFin SPI DMA channel\n");
    > return -ENODEV;
    > }
    > if (set_dma_callback(drv_data->dma_channel,
    > - (void *)dma_irq_handler, drv_data) < 0) {
    > + dma_irq_handler, drv_data) < 0) {
    > dev_dbg(&spi->dev, "Unable to set dma callback\n");
    > return -EPERM;
    > }
    > --
    > 1.5.6.3
    >
    >




    \
     
     \ /
      Last update: 2008-11-20 21:57    [W:0.108 / U:0.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site