lkml.org 
[lkml]   [2008]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: in 2.6.23-rc3-git7 in do_cciss_intr


> -----Original Message-----
> From: Jens Axboe [mailto:jens.axboe@oracle.com]
> Sent: Thursday, November 20, 2008 11:51 AM
> To: Miller, Mike (OS Dev)
> Cc: Randy Dunlap; scsi; James Bottomley; lkml; akpm
> Subject: Re: in 2.6.23-rc3-git7 in do_cciss_intr
>
> On Thu, Nov 20 2008, Miller, Mike (OS Dev) wrote:
> > Jens wrote:
> >
> > > >
> > > > I'd propose just converting it to list_head instead of doing it
> > > > manually. Heck, that should be a 5 minute job, let me
> just do it...
> > > >
> > > > OK, here it is, totally untested (it compiles, must be
> golden...)
> > >
> > > It was missing a list_entry() in fail_all_cmds(), apart
> from that it
> > > was fine. I changed it to use hlist instead, as that is more
> > > appropriate and similar to how it worked before. It also means
> > > there's no extra space usage in the controller structure. I've
> > > tested it and it works fine for me.
> > >
> > > Mike, can you give this a look-over and give me a Reviewed-by or
> > > similar? As an extra bonus, it also gets rid of some code.
> > >
> > > 3 files changed, 33 insertions(+), 46 deletions(-)
> > >
> > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=e303054
> > > e55acd1b6478b8859a5f8648bfaf69a44
> >
> > That works for me. :)
> >
> > Acked-by: Mike Miller <mike.miller@hp.com>
>
> Excellent, thanks Mike. If you could run it through a cycle
> or so of your regular testing, I'd feel 100% confident in it.

Jens,
I'm porting the changes into our build environment so they will go thru the full QA cycle. I'm also testing in my lab before giving the changes to QA.

Thanks for the quick fix.

-- mikem


\
 
 \ /
  Last update: 2008-11-20 20:17    [from the cache]
©2003-2011 Jasper Spaans