lkml.org 
[lkml]   [2008]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 36 of 38] xen: route hardware irqs via Xen
Ingo Molnar wrote:
>> +#ifdef CONFIG_XEN_PCI
>> + irq = xen_register_gsi(gsi, triggering, polarity);
>> + if ((int)irq >= 0)
>> + return irq;
>> +#endif
>>
>
> why not change irq to 'int' and avoid the cast?
>

Yeah, OK.

> also, please eliminate the #ifdef by turning xen_register_gsi() into a
> 'return -1' inline on !CONFIG_XEN_PCI.
>

OK.

>> +#ifdef CONFIG_XEN_PCI
>> + xen_pci_init();
>> +#endif
>>
>
> hide the #ifdef in a header please. (like you already properly do for
> xen_setup_pirqs())
>

OK.

>> + if (rc != 0) {
>> if (!probing_irq(irq))
>> printk(KERN_INFO "Failed to obtain physical IRQ %d\n",
>> irq);
>> + dump_stack();
>>
>
> generally it's better to use WARN() or WARN_ONCE() to get good debug
> feedback and stackdumps. (they also document the reason for the dump)
>

That was really just a temp debug hack; it shouldn't be dumping stack
for probes anyway.

>> @@ -523,8 +526,6 @@
>> } else
>> irq = find_unbound_irq();
>>
>> - spin_unlock(&irq_mapping_update_lock);
>> -
>> set_irq_chip_and_handler_name(irq, &xen_pirq_chip,
>> handle_level_irq, "pirq");
>>
>
> hm, looks like a stray bugfix?
>

Erm, yep.

J


\
 
 \ /
  Last update: 2008-11-20 18:09    [W:0.121 / U:7.364 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site