lkml.org 
[lkml]   [2008]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] el3_common_init() should be __devinit, not __init
    On Sat, Nov 01, 2008 at 10:27:57PM +0300, Alexey Dobriyan wrote:
    > On Sat, Nov 01, 2008 at 07:16:14PM +0000, Al Viro wrote:
    > > On Sat, Nov 01, 2008 at 10:12:50PM +0300, Alexey Dobriyan wrote:
    > > > On Sat, Nov 01, 2008 at 06:20:19PM +0000, Al Viro wrote:
    > > > > -static int __init el3_common_init(struct net_device *dev)
    > > > > +static int __devinit el3_common_init(struct net_device *dev)
    > > >
    > > > Al, here is much better patch:
    > >
    > > [essentially kill devinit/cpuinit]
    > >
    > > What the hell makes it better?
    >
    > Wasting efforts for too little gain?

    And what is the wasted gain - numbers please.
    And please come up with relevant numbers for a number of
    embedded configs. The normal desktop/server usage does not count here.

    For cpuinit/cpuexit the gain turned out to be minimal.
    But I have so far seen _zero_ numbers on the real gain for
    devinit/devexit and meminit/memexit.

    Sam


    \
     
     \ /
      Last update: 2008-11-02 18:33    [W:0.031 / U:4.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site