Messages in this thread | | | From | Denys Vlasenko <> | Subject | Re: [PATCH 1/1] USBHID: correct start/stop cycle | Date | Sun, 2 Nov 2008 20:24:31 +0100 |
| |
On Sunday 02 November 2008 17:50, Helge Deller wrote: > Jiri Slaby wrote: > >>> btw. this is not expected to fix that, but if it does, the better ;). > >> I tried the patch and sadly it didn't fixed the parisc bug. > > > > Could you bisect it? > > I fully bisected it, and the final "buggy" patch seems to have been > Denys Vlasenko's patch: cb8f488c33539f096580e202f5438a809195008f > (see > http://github.com/jonsmirl/digispeaker/commit/cb8f488c33539f096580e202f5438a809195008f) > Denys: Any reason you removed "!prev" in front of "expand_stack"?
Looks like I erroneously thought it can't be NULL, or that expand_upwards() is ok with getting NULL vma parameter.
I looked again and neither is true.
Sorry, looks like I indeed broke this. -- vda
| |