lkml.org 
[lkml]   [2008]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: debugctl msr
Markus,


On Wed, Nov 19, 2008 at 8:20 PM, stephane eranian
<eranian@googlemail.com> wrote:
>
>> For a single ds_release() call matching a corresponding successful
>> ds_request() call, the buffer is freed if and only if it had been
>> allocated by ds.c.
>>
>> Kfree() itself handles NULL pointers and scripts/checkpatch.pl warns on
>> a check for NULL around a kfree() call.
>>
> Yes, I have narrowed this down to the following lines:
> current->mm->total_vm -= context->pages[qual];
> current->mm->locked_vm -= context->pages[qual];

To follow-up on this, the other issue with this code is that you
should not decrease
those two mm fields if the buffer was not allocated by ds.c. So I
think, the modification
I sent you in my patch is actually valid (just for another reason).


\
 
 \ /
  Last update: 2008-11-19 22:03    [W:0.140 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site