lkml.org 
[lkml]   [2008]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ISP1760 driver crashes
On Wed, 19 Nov 2008, Jens Axboe wrote:

> > --- usb-2.6.orig/drivers/scsi/scsi_lib.c
> > +++ usb-2.6/drivers/scsi/scsi_lib.c
> > @@ -1684,7 +1684,7 @@ static void scsi_request_fn(struct reque
> > u64 scsi_calculate_bounce_limit(struct Scsi_Host *shost)
> > {
> > struct device *host_dev;
> > - u64 bounce_limit = 0xffffffff;
> > + u64 bounce_limit = BLK_BOUNCE_HIGH;
> >
> > if (shost->unchecked_isa_dma)
> > return BLK_BOUNCE_ISA;
> >
>
> The best solution is probably to either provide a "doesn't do highmem"
> in the scsi host template, or provide an appropriate DMA mask for the
> pci device to indicate it through that setting instead.

The DMA mask is currently set to NULL. Is that not appropriate for a
device that can't do DMA? If not, then what would be appropriate?

Also, is the patch above not correct?

Alan Stern



\
 
 \ /
  Last update: 2008-11-19 17:37    [W:2.221 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site