[lkml]   [2008]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] n-trig digitizer quirks
On Wed, 19 Nov 2008, Rafi Rubin wrote:

> >> +static int ntrig_input_mapped(struct hid_device *hdev, struct hid_input *hi,
> >> + struct hid_field *field, struct hid_usage *usage,
> >> + unsigned long **bit, int *max)
> >> +{
> >> + unsigned long quirks = (unsigned long)hid_get_drvdata(hdev);
> > This could be removed, as it is never used, right?
> Yes, it wasn't used at the moment, just something left over from using
> hid-lg.c as a template. Since this is the only device known for this
> driver at this point, is it better to keep it shorter and not check for
> the duplicate usage from the driver data or would it be better to add
> the flexibility now?

Please keep the driver as simple as possible. Whenever there are any new
devices in the future, we could easily extend it so that quirk data in
driver_data are taken into account.

> Also, if you do prefer using driver data like that, is the probe
> function necessary to make it work?

Probe function is necesary, you need to parse the report descriptor
(hid_parse()), activate the hardware (hid_hw_start()), etc.


Jiri Kosina

 \ /
  Last update: 2008-11-19 14:55    [W:0.041 / U:6.228 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site