lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC,v2] x86_64: save_args out of line
Jeremy Fitzhardinge wrote:
>
> Not really. At the moment we have two parallel assembly languages which
> say different things about the same instructions. In practice, almost
> nobody understands the cfi parts, so they just get ignored while the x86
> instructions change around them, leaving them either stale or missing.
>
> If we had a sensible macro layer which emits both instructions and cfi
> annotations, it at least means that people who write plain x86
> instructions will simply get no annotations, and people who bother to
> learn the (clearly and fully documented) macros will get the best of both.
>

I think that it would be nice to have macros for the most commonly
annotatable instructions, e.g. push, and stack pointer movement. Just
compactifying the code should improve readability, if perhaps not
writability.

-hpa


\
 
 \ /
  Last update: 2008-11-19 00:51    [W:1.555 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site