Messages in this thread | | | Date | Tue, 18 Nov 2008 16:31:00 -0600 | From | Michael Halcrow <> | Subject | Re: [PATCH] eCryptfs: Allocate up to two scatterlists for crypto ops on keys |
| |
On Fri, Nov 14, 2008 at 05:49:58PM +0100, Leon Woestenberg wrote: > Hello, > > On Fri, Nov 14, 2008 at 5:40 PM, Michael Halcrow <mhalcrow@us.ibm.com> wrote: > > > > - sg_init_table(&dst_sg, 1); > > - sg_init_table(&src_sg, 1); > > Why did you remove the inits?
This initialization is done in virt_to_scatterlist() and is thus redundant for this function.
> With self-checking enabled in the kernel, sg accessor functions will > check on proper initialization and BUGON(). > > It might be your use-case would not hit this, as it seems not to use > sg_ macro's much. > > Regards,
| |