lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] tracing/function-return-tracer: add the overrun field

On Tue, 18 Nov 2008, Ingo Molnar wrote:
> > >
> > > that reminds me: ti->ret_stack[] should be moved to task->ret_stack[].
> > > That way we decouple its size from any kernel stack size limits.
> > > (thread-info resides at one end of the kernel stack, on x86)
> >
> > Yeah, I recommended that to Frederic to save space. But that can be
> > dangerous. Using task instead would be safer with the downside of
> > making the task struct even bigger.
>
> We almost never put new stuff into thread_info - we have the lockdep
> lock stack in the task structure too, for similar reasons.

Yeah, it was just a recommendation, and perhaps not a good one ;-)

Frederic, it is better if you move the array from the thread info to the
task struct. It will take up more memory but it is a hell of a lot safer.
The pro here definitely outways the con.

-- Steve



\
 
 \ /
  Last update: 2008-11-18 16:25    [W:1.851 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site