lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB/ISP1760: Add support for the generic platfrom device centralized driver model (v2)
Bryan Wu wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> v2-v1:
> - cleanup style issue
> - add Kconfig option CONFIG_USB_ISP1760_PDEV
> - isp1760 interrupt is default setup TRIGGER_LOW
Trigger low should be fine.

>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
> drivers/usb/host/Kconfig | 6 +++
> drivers/usb/host/isp1760-if.c | 95 +++++++++++++++++++++++++++++++++++++++++
> include/linux/usb/isp1760.h | 19 ++++++++
> 3 files changed, 120 insertions(+), 0 deletions(-)
> create mode 100644 include/linux/usb/isp1760.h
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 427b3ac..1e38e8a 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -123,6 +123,12 @@ config USB_ISP1760_HCD
> To compile this driver as a module, choose M here: the
> module will be called isp1760.
>
> +config USB_ISP1760_PDEV
> + bool "Support for the generic platfrom device driver model"
> + depends on USB_ISP1760_HCD
> + ---help---
> + Enables support for the generic platfrom device centralized driver model
> +

This is probably a misunderstanding. In the previous email I was refering
the patch [1] which removes the Kconfig entries and makes it
unconditional. Since platform device are always available we can get rid
of depend on PCI || OF in Kconfig and depend just on USB same like isp116x
does. The patch I am refering to is mainline so this won't apply, sorry.
I'm fine with the other parts of the patch.

[1] http://marc.info/?l=linux-usb&m=122563596420156&w=2


Sebastian


\
 
 \ /
  Last update: 2008-11-18 11:55    [W:0.036 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site