lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Large stack usage in fs code (especially for PPC64)

* Christoph Hellwig <hch@infradead.org> wrote:

> On Tue, Nov 18, 2008 at 10:03:25AM +1100, Benjamin Herrenschmidt wrote:
> > On Mon, 2008-11-17 at 15:34 -0500, Steven Rostedt wrote:
> > > Note, I was using a default config that had CONFIG_IRQSTACKS off and
> > > CONFIG_PPC_64K_PAGES on.
> >
> > For one, we definitely need to turn IRQSTACKS on by default ... In fact,
> > I'm pondering just removing the option.
>
> It shouldn't be a user-visible option. It shouldn't on x86 either,
> but there it always gets into the ideological 4k stacks flameware so
> people usually gave up after a while instead of doing the sensibke
> 8k + irqstacks by default, 4k as an option..

yep, i tend to agree that 8k + irqstacks on both 32-bit and 64-bit
would be the sane default. There's just too much gcc and other noise
for us to have that cushion by default on 32-bit too. 64-bit is
already there, on 32-bit we should decouple irqstacks from 4K stacks
and just turn irqstacks on by default.

Life's too short to fight kernel stack overflows - and now we've got
the stack-tracer that will record and show the frame of the worst-ever
kernel stack situation the system was in since bootup. (see Steve's
tracer output in this thread)

Ingo


\
 
 \ /
  Last update: 2008-11-18 11:41    [from the cache]
©2003-2011 Jasper Spaans