lkml.org 
[lkml]   [2008]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix kunmap() argument in sg_miter_stop
On Mon, Nov 17 2008, Ingo Molnar wrote:
>
> * Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > +#define kunmap(p) \
> > + do { \
> > + struct page *__p; \
> > + (void) (&__p == &(p)); \
> > + __kunmap(p); \
> > + } while (0)
> > +
> > +#define kunmap_atomic(a, t) \
> > + do { \
> > + void *__p; \
> > + (void) (&__p == &(a)); \
> > + __kunmap_atomic(a, t); \
> > + } while (0)
>
> Agreed - but please use the typecheck() primitive. (linux/typecheck.h)

Neat, didn't know about that, thanks.

--
Jens Axboe



\
 
 \ /
  Last update: 2008-11-17 09:35    [W:0.121 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site