lkml.org 
[lkml]   [2008]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix kunmap() argument in sg_miter_stop

* Jens Axboe <jens.axboe@oracle.com> wrote:

> +#define kunmap(p) \
> + do { \
> + struct page *__p; \
> + (void) (&__p == &(p)); \
> + __kunmap(p); \
> + } while (0)
> +
> +#define kunmap_atomic(a, t) \
> + do { \
> + void *__p; \
> + (void) (&__p == &(a)); \
> + __kunmap_atomic(a, t); \
> + } while (0)

Agreed - but please use the typecheck() primitive. (linux/typecheck.h)

Ingo


\
 
 \ /
  Last update: 2008-11-17 09:25    [from the cache]
©2003-2011 Jasper Spaans