Messages in this thread | | | Date | Mon, 17 Nov 2008 14:53:59 -0800 | From | Greg KH <> | Subject | Re: chris: struct device - replace bus_id with dev_name(), dev_set_name() |
| |
On Fri, Nov 07, 2008 at 01:01:36PM +0100, Jesper Nilsson wrote: > On Fri, Nov 07, 2008 at 01:38:40AM +0100, Kay Sievers wrote: > > This patch is part of a larger patch series which will remove > > the "char bus_id[20]" name string from struct device. The device > > name is managed in the kobject anyway, and without any size > > limitation, and just needlessly copied into "struct device". > > Thanks, but I think that since this driver has been broken a long time > it is high time to fix it, and I think the fix removes the need for your patch. > > Greg, could you please look this patch over? > > > [CRISv32] Fix IOP fw-loader to use platform_device. > > Change IOP fw-loader to use platform_device instead of > raw device, which should be more correct usage. > > Signed-off-by: Stefan Andersson <stefan.andersson@axis.com> > Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
Looks sane to me. Want me to take it through my tree, or will you be submitting it?
thanks,
greg k-h
| |