Messages in this thread Patch in this message | | | From | David Brownell <> | Subject | [patch 2.6.28-rc5] mfd da903x: section fix | Date | Mon, 17 Nov 2008 11:42:38 -0800 |
| |
From: David Brownell <dbrownell@users.sourceforge.net>
This fixes the following section warning:
WARNING: vmlinux.o(.devinit.text+0x3d36): Section mismatch in reference from the function da903x_add_subdevs() to the function .devexit.text:da903x_remove_subdevs() The function __devinit da903x_add_subdevs() references a function __devexit da903x_remove_subdevs(). This is often seen when error handling in the init function uses functionality in the exit path. The fix is often to remove the __devexit annotation of da903x_remove_subdevs() so it may be used outside an exit section.
It might be nice to have an "init and exit" section annotation for such cases; in this case the waste is only about 40 bytes (x86 test build).
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> --- drivers/mfd/da903x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/mfd/da903x.c +++ b/drivers/mfd/da903x.c @@ -435,13 +435,13 @@ static const struct i2c_device_id da903x }; MODULE_DEVICE_TABLE(i2c, da903x_id_table); -static int __devexit __remove_subdev(struct device *dev, void *unused) +static int __remove_subdev(struct device *dev, void *unused) { platform_device_unregister(to_platform_device(dev)); return 0; } -static int __devexit da903x_remove_subdevs(struct da903x_chip *chip) +static int da903x_remove_subdevs(struct da903x_chip *chip) { return device_for_each_child(chip->dev, NULL, __remove_subdev); }
| |