Messages in this thread | | | Date | Mon, 17 Nov 2008 09:57:24 -0800 | From | Hiroshi Shimamoto <> | Subject | Re: [PATCH 1/5] x86: ia32_signal: cleanup macro COPY |
| |
Américo Wang wrote: > On Sat, Nov 15, 2008 at 3:24 AM, Hiroshi Shimamoto > <h-shimamoto@ct.jp.nec.com> wrote: >> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> >> >> Impact: cleanup >> >> No need to use temporary variable in this case. >> >> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> >> --- >> arch/x86/ia32/ia32_signal.c | 6 ++---- >> 1 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c >> index e886907..a28790a 100644 >> --- a/arch/x86/ia32/ia32_signal.c >> +++ b/arch/x86/ia32/ia32_signal.c >> @@ -197,10 +197,8 @@ struct rt_sigframe >> /* fp state follows here */ >> }; >> >> -#define COPY(x) { \ >> - unsigned int reg; \ >> - err |= __get_user(reg, &sc->x); \ >> - regs->x = reg; \ >> +#define COPY(x) { \ >> + err |= __get_user(regs->x, &sc->x); \ >> }
Thanks for reviewing this!
> > Then you can also kill the braces now. :)
I guess, checkpatch will complain. Personally I don't care.
> > What's more, if I saw it correctly, the belowing two __get_user() calls can > also be replaced by COPY().
I'm sorry, I cannot catch about this. Which __get_user()?
thanks, Hiroshi Shimamoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |