Messages in this thread | | | Date | Tue, 18 Nov 2008 02:32:26 +0900 | From | "KOSAKI Motohiro" <> | Subject | Re: [PATCH] vmscan: fix get_scan_ratio comment |
| |
2008/11/18 Rik van Riel <riel@redhat.com>: > > Fix the old comment on the scan ratio calculations. > > Signed-off-by: Rik van Riel <riel@redhat.com> > --- > mm/vmscan.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Index: linux-2.6.28-rc5/mm/vmscan.c > =================================================================== > --- linux-2.6.28-rc5.orig/mm/vmscan.c 2008-11-16 17:47:13.000000000 -0500 > +++ linux-2.6.28-rc5/mm/vmscan.c 2008-11-17 12:05:03.000000000 -0500 > @@ -1386,9 +1386,9 @@ static void get_scan_ratio(struct zone * > file_prio = 200 - sc->swappiness; > > /* > - * anon recent_rotated[0] > - * %anon = 100 * ----------- / ----------------- * IO cost > - * anon + file rotate_sum > + * recent_scanned[anon] > + * %anon = -------------------- * sc->swappiness > + * recent_rotated[anon] > */ > ap = (anon_prio + 1) * (zone->recent_scanned[0] + 1); > ap /= zone->recent_rotated[0] + 1;
looks good to me, absolutely. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |