Messages in this thread | | | Date | Mon, 17 Nov 2008 11:57:09 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] leds: Add WM8350 LED driver |
| |
On Fri, Nov 14, 2008 at 03:19:08PM -0800, Andrew Morton wrote:
> > + led_classdev_unregister(&led->cdev); > > + schedule_work(&led->work); > > + flush_scheduled_work();
> The schedule_work() is unexpected and I can't immediately see why it's > here. If it is indeed correct, I'd suggest the addition of a comment.
Me either, I'll remove it and fix the other things you raised too. Thanks.
| |