Messages in this thread |  | | Date | Mon, 17 Nov 2008 10:19:59 +0530 | From | Balbir Singh <> | Subject | Re: [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v4) |
| |
Li Zefan wrote: >> + /* >> + * If parent's use_hiearchy is set, we can't make any modifications >> + * in the child subtrees. If it is unset, then the change can >> + * occur, provided the current cgroup has no children. >> + * >> + * For the root cgroup, parent_mem is NULL, we allow value to be >> + * set if there are no children. >> + */ >> + if (!parent_mem || (!parent_mem->use_hierarchy && >> + (val == 1 || val == 0))) { > > Should be : > > if ((!parent_mem || !parent_mem->use_hierarchy) && > (val == 1 || val == 0)) {
Yes, we need to validate values for root cgroup as well. Thanks for the comments
-- Balbir
|  |