Messages in this thread |  | | Date | Mon, 17 Nov 2008 12:46:05 +0800 | From | Li Zefan <> | Subject | Re: [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v4) |
| |
> + /* > + * If parent's use_hiearchy is set, we can't make any modifications > + * in the child subtrees. If it is unset, then the change can > + * occur, provided the current cgroup has no children. > + * > + * For the root cgroup, parent_mem is NULL, we allow value to be > + * set if there are no children. > + */ > + if (!parent_mem || (!parent_mem->use_hierarchy && > + (val == 1 || val == 0))) {
Should be :
if ((!parent_mem || !parent_mem->use_hierarchy) && (val == 1 || val == 0)) {
> + if (list_empty(&cont->children)) > + mem->use_hierarchy = val; > + else > + retval = -EBUSY; > + } else > + retval = -EINVAL; > + cgroup_unlock(); > + > + return retval; > +}
|  |